Solution #2190
Solution #2190
Conversation
There was a problem hiding this comment.
Great job on implementing the formatDate function! 🎉 It meets the task requirements and handles the conversion of date formats effectively. While there are some assumptions about the position of separators in the format arrays, the core functionality is intact. For future improvements, consider making the separator handling more dynamic to accommodate various date formats. Keep up the good work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -8,7 +8,38 @@ | |||
| * @returns {string} | |||
| */ | |||
| function formatDate(date, fromFormat, toFormat) { | |||
| // write code here | |||
| } | |||
| const partsDate = date.split(fromFormat[3]); | |||
There was a problem hiding this comment.
The code assumes that the separator is always at index 3 in the fromFormat array. This assumption may not hold true for all date formats. Consider dynamically determining the separator based on the format string.
| const month = partsDate[fromFormat.indexOf('MM')]; | ||
| const day = partsDate[fromFormat.indexOf('DD')]; | ||
|
|
||
| const newSper = toFormat[3]; |
There was a problem hiding this comment.
Similar to the issue with fromFormat, the code assumes that the separator is at index 3 in the toFormat array. This might not be correct for all formats. Consider a more flexible approach to determine the separator.
|
|
||
| toFormat.pop(); |
There was a problem hiding this comment.
Removing the last element of toFormat using pop() might not be the correct approach if the separator is not at the last position. This could lead to incorrect date formatting.
No description provided.